Skip to content

feat(components, data-modeling): add portal version of the Drawer component; use new DrawerSection in data-modeling COMPASS-9610 #7138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2025
Merged

feat(components, data-modeling): add portal version of the Drawer component; use new DrawerSection in data-modeling COMPASS-9610 #7138

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a88718
feat(components, data-modeling): add portal version of the Drawer com…
gribnoysup Jul 24, 2025
9fc68c9
Merge remote-tracking branch 'origin/main' into COMPASS-9610-portal-d…
gribnoysup Jul 24, 2025
2e07222
chore(components): add order prop
gribnoysup Jul 24, 2025
e94a131
Merge remote-tracking branch 'origin/main' into COMPASS-9610-portal-d…
gribnoysup Jul 24, 2025
e473c9c
chore(data-modeling): remove extra padding; adjust tests
gribnoysup Jul 24, 2025
8c15510
chore(data-modeling): temporarily skip unit tests in electron runtime
gribnoysup Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/compass-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
"mongodb-query-util": "^2.5.3",
"polished": "^4.2.2",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-hotkeys-hook": "^4.3.7",
"react-intersection-observer": "^8.34.0",
"react-virtualized-auto-sizer": "^1.0.6",
Expand All @@ -110,7 +111,6 @@
"chai": "^4.3.4",
"mocha": "^10.2.0",
"nyc": "^15.1.0",
"react-dom": "^17.0.2",
"sinon": "^9.0.0",
"typescript": "^5.8.3"
},
Expand Down
55 changes: 29 additions & 26 deletions packages/compass-components/src/components/compass-components-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { SignalHooksProvider } from './signal-popover';
import { RequiredURLSearchParamsProvider } from './links/link';
import { StackedComponentProvider } from '../hooks/use-stacked-component';
import { ContextMenuProvider } from './context-menu';
import { DrawerContentProvider } from './drawer-portal';

type GuideCueProviderProps = React.ComponentProps<typeof GuideCueProvider>;

Expand Down Expand Up @@ -131,33 +132,35 @@ export const CompassComponentsProvider = ({
darkMode={darkMode}
popoverPortalContainer={popoverPortalContainer}
>
<StackedComponentProvider zIndex={stackedElementsZIndex}>
<RequiredURLSearchParamsProvider
utmSource={utmSource}
utmMedium={utmMedium}
>
<GuideCueProvider
onNext={onNextGuideGue}
onNextGroup={onNextGuideCueGroup}
<DrawerContentProvider>
<StackedComponentProvider zIndex={stackedElementsZIndex}>
<RequiredURLSearchParamsProvider
utmSource={utmSource}
utmMedium={utmMedium}
>
<SignalHooksProvider {...signalHooksProviderProps}>
<ConfirmationModalArea>
<ContextMenuProvider disabled={disableContextMenus}>
<ToastArea>
{typeof children === 'function'
? children({
darkMode,
portalContainerRef: setPortalContainer,
scrollContainerRef: setScrollContainer,
})
: children}
</ToastArea>
</ContextMenuProvider>
</ConfirmationModalArea>
</SignalHooksProvider>
</GuideCueProvider>
</RequiredURLSearchParamsProvider>
</StackedComponentProvider>
<GuideCueProvider
onNext={onNextGuideGue}
onNextGroup={onNextGuideCueGroup}
>
<SignalHooksProvider {...signalHooksProviderProps}>
<ConfirmationModalArea>
<ContextMenuProvider disabled={disableContextMenus}>
<ToastArea>
{typeof children === 'function'
? children({
darkMode,
portalContainerRef: setPortalContainer,
scrollContainerRef: setScrollContainer,
})
: children}
</ToastArea>
</ContextMenuProvider>
</ConfirmationModalArea>
</SignalHooksProvider>
</GuideCueProvider>
</RequiredURLSearchParamsProvider>
</StackedComponentProvider>
</DrawerContentProvider>
</LeafyGreenProvider>
);
};
Loading
Loading