chore(data-modeling): use change on blur hook for collection name for consistency #7190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
added
the
no-title-validation
gribnoysup
force-pushed
the
use-change-on-blur-for-collection-name
branch
from
8238911 to
34dfadf
Compare
addaleax
approved these changes
Aug 12, 2025
Anemy
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes custom wiring between useState / useLayoutEffect / onChange / onBlur callbacks to control the input in favor of a shared hook that we use for another similar field already. Validation is still controlled from the outside for now
@Anemy just wanted to clarify my point: you don't really need to update the hook to also handle the validation (although you definitely can) to already minimize the amount of similar code that can be shared, the amount of extra useEffects and extra wiring will just grow the more new fields we will be adding there