Skip to content

chore(data-modeling): use change on blur hook for collection name for consistency #7190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

chore(data-modeling): use change on blur hook for collection name for consistency #7190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 17 additions & 24 deletions packages/compass-data-modeling/src/components/drawer/collection-drawer-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useCallback, useLayoutEffect, useMemo, useState } from 'react';
import React, { useMemo } from 'react';
import { connect } from 'react-redux';
import toNS from 'mongodb-ns';
import type { Relationship } from '../../services/data-model-storage';
Expand Down Expand Up @@ -116,8 +116,21 @@ const CollectionDrawerContent: React.FunctionComponent<
onNoteChange,
onRenameCollection,
}) => {
const [collectionName, setCollectionName] = useState(
() => toNS(namespace).collection
const { value: collectionName, ...nameInputProps } = useChangeOnBlur(
toNS(namespace).collection,
(collectionName) => {
const trimmedName = collectionName.trim();
if (trimmedName === toNS(namespace).collection) {
return;
}
if (!isCollectionNameValid) {
return;
}
onRenameCollection(
namespace,
`${toNS(namespace).database}.${trimmedName}`
);
}
);

const {
Expand All @@ -128,23 +141,6 @@ const CollectionDrawerContent: React.FunctionComponent<
[collectionName, namespaces, namespace]
);

useLayoutEffect(() => {
setCollectionName(toNS(namespace).collection);
}, [namespace]);

const onBlurCollectionName = useCallback(() => {
const trimmedName = collectionName.trim();
if (trimmedName === toNS(namespace).collection) {
return;
}

if (!isCollectionNameValid) {
return;
}

onRenameCollection(namespace, `${toNS(namespace).database}.${trimmedName}`);
}, [collectionName, namespace, onRenameCollection, isCollectionNameValid]);

const noteInputProps = useChangeOnBlur(note, (newNote) => {
onNoteChange(namespace, newNote);
});
Expand All @@ -157,12 +153,9 @@ const CollectionDrawerContent: React.FunctionComponent<
label="Name"
sizeVariant="small"
value={collectionName}
{...nameInputProps}
state={isCollectionNameValid ? undefined : 'error'}
errorMessage={collectionNameEditErrorMessage}
onChange={(e) => {
setCollectionName(e.target.value);
}}
onBlur={onBlurCollectionName}
/>
</DMFormFieldContainer>
</DMDrawerSection>
Expand Down
Loading