Skip to content

chore(e2e-tests): add waitForAnimations for document results #7210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2025
Merged

chore(e2e-tests): add waitForAnimations for document results #7210

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4de4d0f
chore(e2e-tests): add waitForAnimations for document results
Anemy Aug 18, 2025
9a24b4a
fixup: only run when the docs list is displayed
Anemy Aug 18, 2025
dc5e11b
fixup: use the virtual list container as it is what resizes
Anemy Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/compass-crud/src/components/table-view/document-table-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,6 +1005,7 @@ class DocumentTableView extends React.Component<DocumentTableViewProps> {
'document-table-view-container',
this.props.darkMode && 'document-table-view-container-darkmode'
)}
data-testid="document-list"
>
<div className={cx('ag-parent', this.props.className)}>
<BreadcrumbComponent
Expand Down
1 change: 1 addition & 0 deletions packages/compass-crud/src/components/virtualized-document-json-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const VirtualizedDocumentJsonView: React.FC<
renderItem={renderItem}
estimateItemInitialHeight={estimateDocumentInitialHeight}
rowGap={spacing[200]}
dataTestId="document-list"
itemDataTestId="document-json-item"
// Keeping the overscanCount low here helps us avoid scroll dangling
// issues
Expand Down
11 changes: 11 additions & 0 deletions packages/compass-e2e-tests/helpers/commands/run-find.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,16 @@ export async function runFind(
const resultId = await browser.getQueryId(tabName);
return resultId !== initialResultId;
});

// Wait for animations to finish on the documents or schema page.
// Because we're virtualizing the list on crud, the query results may
// change after the resultId has changed.
if (tabName === 'Documents') {
await browser.waitForAnimations(Selectors.DocumentList);
} else if (tabName === 'Schema') {
/* not virtualized */
} else {
throw new Error(`Unknown tab name ${tabName}`);
}
}
}
1 change: 1 addition & 0 deletions packages/compass-e2e-tests/helpers/selectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,7 @@ export const ImportFileOption =
export const DocumentListEntry = '[data-testid="editable-document"]';
export const DocumentJSONEntry = '[data-testid="document-json-item"]';
export const DocumentExpandButton = '[data-testid="expand-document-button"]';
export const DocumentList = '[data-testid="document-list"]';
export const SelectJSONView = '[data-testid="toolbar-view-json"]';
export const SelectTableView = '[data-testid="toolbar-view-table"]';
export const SelectListView = '[data-testid="toolbar-view-list"]';
Expand Down
Loading