Skip to content

chore(compass-assistant): hide the performance insight entrypoints behind its own feature flag COMPASS-9794 #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
+36 −1
Merged

chore(compass-assistant): hide the performance insight entrypoints behind its own feature flag COMPASS-9794 #7281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ca6c2
hide the performance insight entrypoints behind its own feature flag
lerouxb Sep 4, 2025
6154c4e
add a test
lerouxb Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/compass-assistant/src/compass-assistant-provider.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,24 @@ describe('useAssistantActions', function () {
},
});

expect(Object.keys(result.current)).to.have.length.greaterThan(0);
expect(result.current.interpretExplainPlan).to.be.a('function');
expect(result.current.interpretConnectionError).to.be.a('function');
expect(result.current.tellMoreAboutInsight).to.be.undefined;
});

it('returns actions when both AI features and assistant flag AND enablePerformanceInsightsEntrypoints are enabled', function () {
const { result } = renderHook(() => useAssistantActions(), {
wrapper: createWrapper(createMockChat({ messages: [] })),
preferences: {
enableAIAssistant: true,
enablePerformanceInsightsEntrypoints: true,
enableGenAIFeatures: true,
enableGenAIFeaturesAtlasOrg: true,
cloudFeatureRolloutAccess: { GEN_AI_COMPASS: true },
},
});

expect(Object.keys(result.current)).to.have.length.greaterThan(0);
expect(result.current.interpretExplainPlan).to.be.a('function');
expect(result.current.interpretConnectionError).to.be.a('function');
Expand Down
8 changes: 7 additions & 1 deletion packages/compass-assistant/src/compass-assistant-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ export function useAssistantActions(): AssistantActionsType {
const actions = useContext(AssistantActionsContext);
const isAIFeatureEnabled = useIsAIFeatureEnabled();
const isAssistantFlagEnabled = usePreference('enableAIAssistant');
const isPerformanceInsightEntrypointsEnabled = usePreference(
'enablePerformanceInsightsEntrypoints'
);

if (!isAIFeatureEnabled || !isAssistantFlagEnabled) {
return {
getIsAssistantEnabled: () => false,
Expand All @@ -106,7 +110,9 @@ export function useAssistantActions(): AssistantActionsType {
return {
interpretExplainPlan,
interpretConnectionError,
tellMoreAboutInsight,
tellMoreAboutInsight: isPerformanceInsightEntrypointsEnabled
? tellMoreAboutInsight
: undefined,
getIsAssistantEnabled: () => true,
};
}
Expand Down
11 changes: 11 additions & 0 deletions packages/compass-preferences-model/src/feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export type FeatureFlags = {
enableSearchActivationProgramP1: boolean;
enableUnauthenticatedGenAI: boolean;
enableAIAssistant: boolean;
enablePerformanceInsightsEntrypoints: boolean;
};

export const featureFlags: Required<{
Expand Down Expand Up @@ -178,4 +179,14 @@ export const featureFlags: Required<{
short: 'Enable AI Assistant',
},
},

/*
* Feature flag for AI Assistant's performance insight entrypoints.
*/
enablePerformanceInsightsEntrypoints: {
stage: 'development',
description: {
short: 'Enable the performance insights AI Assistant entrypoints',
},
},
};
Loading