Skip to content

chore(data-modeling): update drawer icon label to be generic #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

chore(data-modeling): update drawer icon label to be generic #7356

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b71b8
chore(data-modeling): update drawer icon label to be generic
Anemy Sep 22, 2025
6a8262b
fixup: used better label and title naming, drive by inline definition…
Anemy Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 84 additions & 75 deletions packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,84 +53,93 @@ function DiagramEditorSidePanel({
onDeleteRelationship,
onDeleteField,
}: DiagramEditorSidePanelProps) {
const { content, label, actions, handleAction } = useMemo(() => {
if (selectedItems?.type === 'collection') {
return {
label: selectedItems.label,
content: (
<CollectionDrawerContent
key={selectedItems.id}
namespace={selectedItems.id}
></CollectionDrawerContent>
),
actions: [
{
action: 'delete',
label: 'Delete Collection',
icon: 'Trash' as const,
const { content, drawerIconLabel, label, actions, handleAction } =
useMemo(() => {
if (selectedItems?.type === 'collection') {
return {
label: selectedItems.label,
drawerIconLabel: 'Collection Configuration',
content: (
<CollectionDrawerContent
key={selectedItems.id}
namespace={selectedItems.id}
></CollectionDrawerContent>
),
actions: [
{
action: 'delete',
label: 'Delete Collection',
icon: 'Trash' as const,
},
],
handleAction: (actionName: string) => {
if (actionName === 'delete') {
onDeleteCollection(selectedItems.id);
}
},
],
handleAction: (actionName: string) => {
if (actionName === 'delete') {
onDeleteCollection(selectedItems.id);
}
},
};
}
};
}

if (selectedItems?.type === 'relationship') {
return {
label: selectedItems.label,
content: (
<RelationshipDrawerContent
key={selectedItems.id}
relationshipId={selectedItems.id}
></RelationshipDrawerContent>
),
actions: [
{ action: 'delete', label: 'Delete', icon: 'Trash' as const },
],
handleAction: (actionName: string) => {
if (actionName === 'delete') {
onDeleteRelationship(selectedItems.id);
}
},
};
}
if (selectedItems?.type === 'relationship') {
return {
label: selectedItems.label,
drawerIconLabel: 'Relationship Configuration',
content: (
<RelationshipDrawerContent
key={selectedItems.id}
relationshipId={selectedItems.id}
></RelationshipDrawerContent>
),
actions: [
{ action: 'delete', label: 'Delete', icon: 'Trash' as const },
],
handleAction: (actionName: string) => {
if (actionName === 'delete') {
onDeleteRelationship(selectedItems.id);
}
},
};
}

if (selectedItems?.type === 'field') {
return {
label: selectedItems.label,
content: (
<FieldDrawerContent
key={`${selectedItems.namespace}.${JSON.stringify(
selectedItems.fieldPath
)}`}
namespace={selectedItems.namespace}
fieldPath={selectedItems.fieldPath}
></FieldDrawerContent>
),
actions: [
...(!isIdField(selectedItems.fieldPath)
? [
{
action: 'delete',
label: 'Delete Field',
icon: 'Trash' as const,
},
]
: []),
],
handleAction: (actionName: string) => {
if (actionName === 'delete') {
onDeleteField(selectedItems.namespace, selectedItems.fieldPath);
}
},
};
}
if (selectedItems?.type === 'field') {
return {
label: selectedItems.label,
drawerIconLabel: 'Field Configuration',
content: (
<FieldDrawerContent
key={`${selectedItems.namespace}.${JSON.stringify(
selectedItems.fieldPath
)}`}
namespace={selectedItems.namespace}
fieldPath={selectedItems.fieldPath}
></FieldDrawerContent>
),
actions: [
...(!isIdField(selectedItems.fieldPath)
? [
{
action: 'delete',
label: 'Delete Field',
icon: 'Trash' as const,
},
]
: []),
],
handleAction: (actionName: string) => {
if (actionName === 'delete') {
onDeleteField(selectedItems.namespace, selectedItems.fieldPath);
}
},
};
}

return { content: null };
}, [selectedItems, onDeleteCollection, onDeleteRelationship, onDeleteField]);
return { content: null };
}, [
selectedItems,
onDeleteCollection,
onDeleteRelationship,
onDeleteField,
]);

if (!content) {
return null;
Expand Down Expand Up @@ -160,7 +169,7 @@ function DiagramEditorSidePanel({
></ItemActionControls>
</div>
}
label={label}
label={drawerIconLabel}
glyph="Wrench"
autoOpen
>
Expand Down
Loading