-
Notifications
You must be signed in to change notification settings - Fork 237
feat(database-collections): add uncompressed data stat field COMPASS-7691 #7357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add uncompressed data field in database and collections list. Also, update the tooltip for storage and uncompressed data size fields so that it gets easier for users to understand these fields. On branch feat/uncompressed-data-size Changes to be committed: modified: packages/compass-components/src/components/inline-definition.tsx modified: packages/databases-collections-list/src/collections.tsx modified: packages/databases-collections-list/src/databases.tsx modified: packages/databases-collections-list/src/index.spec.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an uncompressed data field to both database and collection list views in MongoDB Compass, providing users with separate visibility into storage size and uncompressed data size. The change also updates tooltips to better explain the difference between these metrics.
- Adds a new "Uncompressed data" field alongside the existing "Storage" field
- Updates tooltip text to clarify the distinction between storage and uncompressed data
- Modifies CSS styling to support break-spaces for better tooltip text wrapping
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
File | Description |
---|---|
packages/databases-collections-list/src/index.spec.tsx | Updates test expectations to verify new uncompressed data field display |
packages/databases-collections-list/src/databases.tsx | Adds uncompressed data field and updated tooltips for database list view |
packages/databases-collections-list/src/collections.tsx | Adds uncompressed data field and updated tooltips for collections list view |
packages/compass-components/src/components/inline-definition.tsx | Adds CSS styling for proper text wrapping in tooltips |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is all good so far, but I think a core issue with COMPASS-7691 is that we do not communicate to users right now that "Storage" is the result of subtracting freeStorageSize
from storageSize
, and that we don't communicate that fact (i.e. users may work under the incorrect assumption that freeStorageSize === 0
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I assume you have merge access to this repo, lmk if I'm mistaken 🙂
…t/uncompressed-data-size
…OMPASS-7691 (#7357)" This reverts commit e8c45e5.
…OMPASS-7691 (#7357)" (#7426) This reverts commit e8c45e5.
Description
Add uncompressed data field in database and collections list. Also, update the tooltip for storage and uncompressed data size fields so that it gets easier for users to understand these fields.
Checklist
Motivation and Context
Open Questions
For uncompressed data field,
dataSize
was used when in databases list anddocumentsSize
when in collections list view.Dependents
Types of changes