Skip to content

Conversation

ivandevp
Copy link
Collaborator

Description

Add uncompressed data field in database and collections list. Also, update the tooltip for storage and uncompressed data size fields so that it gets easier for users to understand these fields.

Screenshot 2025-09-23 at 10 14 06 AM Screenshot 2025-09-23 at 10 14 28 AM

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

For uncompressed data field, dataSize was used when in databases list and documentsSize when in collections list view.

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Add uncompressed data field in database and collections list.
Also, update the tooltip for storage and uncompressed data size
fields so that it gets easier for users to understand these fields.

On branch feat/uncompressed-data-size
Changes to be committed:
	modified:   packages/compass-components/src/components/inline-definition.tsx
	modified:   packages/databases-collections-list/src/collections.tsx
	modified:   packages/databases-collections-list/src/databases.tsx
	modified:   packages/databases-collections-list/src/index.spec.tsx
@ivandevp ivandevp self-assigned this Sep 23, 2025
@ivandevp ivandevp requested a review from a team as a code owner September 23, 2025 08:16
@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 08:16
@ivandevp ivandevp requested a review from Anemy September 23, 2025 08:16
@ivandevp ivandevp added the feat label Sep 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an uncompressed data field to both database and collection list views in MongoDB Compass, providing users with separate visibility into storage size and uncompressed data size. The change also updates tooltips to better explain the difference between these metrics.

  • Adds a new "Uncompressed data" field alongside the existing "Storage" field
  • Updates tooltip text to clarify the distinction between storage and uncompressed data
  • Modifies CSS styling to support break-spaces for better tooltip text wrapping

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
packages/databases-collections-list/src/index.spec.tsx Updates test expectations to verify new uncompressed data field display
packages/databases-collections-list/src/databases.tsx Adds uncompressed data field and updated tooltips for database list view
packages/databases-collections-list/src/collections.tsx Adds uncompressed data field and updated tooltips for collections list view
packages/compass-components/src/components/inline-definition.tsx Adds CSS styling for proper text wrapping in tooltips

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all good so far, but I think a core issue with COMPASS-7691 is that we do not communicate to users right now that "Storage" is the result of subtracting freeStorageSize from storageSize, and that we don't communicate that fact (i.e. users may work under the incorrect assumption that freeStorageSize === 0)

@ivandevp ivandevp requested a review from addaleax September 23, 2025 16:25
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

I assume you have merge access to this repo, lmk if I'm mistaken 🙂

@ivandevp ivandevp merged commit e8c45e5 into main Sep 24, 2025
60 checks passed
@ivandevp ivandevp deleted the feat/uncompressed-data-size branch September 24, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants