Skip to content

fix: use stacked component styles for tooltip COMPASS-8299 #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: use stacked component styles for tooltip COMPASS-8299 #7413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76c84e5
fix(compass-components): use stacked component styles for tooltip COM…
paula-stacho Oct 2, 2025
e2b09f6
Update packages/compass-components/src/components/leafygreen.tsx
paula-stacho Oct 2, 2025
96c7aae
fix type
paula-stacho Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/compass-components/src/components/leafygreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ import LeafyGreenTextInput from '@leafygreen-ui/text-input';
import { SearchInput } from '@leafygreen-ui/search-input';
export { usePrevious, useMergeRefs } from '@leafygreen-ui/hooks';
import Toggle from '@leafygreen-ui/toggle';
import Tooltip from '@leafygreen-ui/tooltip';
import LGTooltip from '@leafygreen-ui/tooltip';
import {
H1,
H2,
Expand All @@ -92,8 +92,12 @@ import {
ComboboxOption,
ComboboxGroup,
} from '@leafygreen-ui/combobox';
import { withStackedComponentStyles } from '../hooks/use-stacked-component';



// 2. Wrap and make any changes/workaround to leafygreen components.
const Tooltip = withStackedComponentStyles(LGTooltip);
const Icon = ({
size,
...rest
Expand Down
4 changes: 2 additions & 2 deletions packages/compass-components/src/hooks/use-stacked-component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ type StackedComponentProps<T extends boolean> = T extends true

// TODO(LG-4109): This should be eventually supported by the LG design system
export const withStackedComponentStyles = function <ComponentProps>(
WrappedComponent: ComponentType<ComponentProps>
): ComponentType<ComponentProps> {
WrappedComponent: React.FC<ComponentProps>
): React.FC<ComponentProps> {
const ComponentWithStackedStyles = (
props: ComponentProps,
ref: ForwardedRef<ComponentType<ComponentProps>>
Expand Down
Loading