Skip to content

fix: clear AttemptStateMap after successful sign-in and optin COMPASS-7342 #7418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clear AttemptStateMap after successful sign-in and optin COMPASS-7342 #7418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/atlas-service/src/store/atlas-signin-reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const AttemptStateMap = new Map<number, AttemptState>();

export let attemptId = 0;

export function getAttempt(id?: number | null): AttemptState {
function getAttempt(id?: number | null): AttemptState {
Copy link
Preview

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Removing the export from getAttempt changes it from a public to a module-private function, which may break existing imports if it was used elsewhere. If this was intentional, document the change or update callers; if unintentional, restore the export keyword.

Suggested change
function getAttempt(id?: number | null): AttemptState {
export function getAttempt(id?: number | null): AttemptState {

Copilot uses AI. Check for mistakes.

if (!id) {
id = ++attemptId;
const controller = new AbortController();
Expand Down Expand Up @@ -360,6 +360,7 @@ export const signIn = (): AtlasSignInThunkAction<Promise<void>> => {
});
dispatch({ type: AtlasSignInActions.Success, userInfo });
atlasAuthService.emit('signed-in');
AttemptStateMap.clear();
resolve(userInfo);
} catch (err) {
// Only handle error if sign in wasn't aborted by the user, otherwise it
Expand Down
1 change: 1 addition & 0 deletions packages/compass-generative-ai/src/store/atlas-optin-reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ export const optIn = (): GenAIAtlasOptInThunkAction<Promise<void>> => {
throwIfAborted(signal);
await atlasAiService.optIntoGenAIFeatures();
dispatch(atlasAiServiceOptedIn());
AttemptStateMap.clear();
resolve();
} catch (err) {
if (signal.aborted) {
Expand Down
Loading