Skip to content

Conversation

@W-A-James
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:eslint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review December 5, 2024 21:41
@W-A-James
Copy link
Contributor Author

Hold until #24 merges

@W-A-James W-A-James added the Blocked Pull request is being held until other work is completed label Dec 5, 2024
@W-A-James W-A-James changed the base branch from main to NODE-6559 December 5, 2024 21:48
Base automatically changed from NODE-6559 to main December 6, 2024 19:56
@W-A-James W-A-James removed the Blocked Pull request is being held until other work is completed label Dec 6, 2024
@nbbeeken nbbeeken self-assigned this Dec 6, 2024
@nbbeeken nbbeeken added the Primary Review Pull request is being reviewed by primary reviewer label Dec 6, 2024
@nbbeeken nbbeeken merged commit f644211 into main Dec 6, 2024
5 checks passed
@nbbeeken nbbeeken deleted the NODE-6559-ci branch December 6, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review Pull request is being reviewed by primary reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants