fix(NODE-6706): Move creation and deletion of install location #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
force-pushed
the
create-tmp-dir-per-suite
branch
from
4fa73bd to
0eefbd9
Compare
W-A-James
changed the title
Contributor
Author
|
Note that failing test only fails on [email protected]. This is similar to things we've seen in the past when making changes to this library where installing one or another version of bson suddenly stops working. |
nbbeeken
added
the
Primary Review
nbbeeken
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Suite.runfromTask.runIs there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:eslintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript