Skip to content

Conversation

nirinchev
Copy link
Collaborator

@nirinchev nirinchev commented Oct 28, 2024

Description

This moves the download-url package into the monorepo. There are no code changes but package.json has been updated with a few dependency updates as well as some metadata changes to reflect the move. Here's the diff:

@@ -35,21 +35,21 @@
     "semver": "^7.1.1"
   },
   "devDependencies": {
+    "@types/mocha": "^9.1.1",
+    "@types/node": "^17.0.35",
+    "@typescript-eslint/eslint-plugin": "^5.59.0",
+    "@typescript-eslint/parser": "^5.59.0",
-    "@types/mocha": "^8.2.1",
-    "@types/node": "^16.4.10",
-    "@typescript-eslint/eslint-plugin": "^4.18.0",
-    "@typescript-eslint/parser": "^4.18.0",
     "eslint": "^7.22.0",
+    "eslint-config-semistandard": "^17.0.0",
+    "eslint-config-standard": "^17.1.0",
-    "eslint-config-semistandard": "^15.0.1",
-    "eslint-config-standard": "^16.0.2",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-promise": "^6.1.1",
-    "eslint-plugin-promise": "^4.3.1",
     "gen-esm-wrapper": "^1.1.1",
+    "mocha": "^8.4.0",
-    "mocha": "^10.0.0",
     "nyc": "^15.1.0",
+    "ts-node": "^10.9.2",
+    "typescript": "^5.0.4"
-    "ts-node": "^9.1.1",
-    "typescript": "^4.2.3"
   },
   "keywords": [
     "mongodb",
@@ -57,10 +57,9 @@
   ],
   "repository": {
     "type": "git",
+    "url": "https://github.com/mongodb-js/devtools-shared.git"
-    "url": "http://github.com/mongodb-js/download-url.git"
   },
   "author": "Lucas Hrabovsky <[email protected]> (http://imlucas.com)",
   "license": "Apache-2.0",
+  "homepage": "https://github.com/mongodb-js/devtools-shared/tree/main/packages/download-url"
-  "homepage": "http://github.com/mongodb-js/download-url"
 }

Commit breakdown

  1. c1d6ead - Copies over the files from https://github.com/mongodb-js/download-url with no functional changes.
  2. 5ea1da5 - Changes the config files to adhere to the conventions used by the devtools-shared repo (ran create-workspace and carried over package.json and tsconfig.json settings from the original package).
  3. 32a46f9 - Fixes issues reported by eslint and runs prettier.

@nirinchev nirinchev requested a review from addaleax October 28, 2024 12:15
@addaleax addaleax merged commit f557915 into main Oct 29, 2024
5 checks passed
@addaleax addaleax deleted the ni/download-url branch October 29, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants