fix(ci): use [email protected] to avoid failing silently #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
force-pushed
the
gagik/fix-tests
branch
3 times, most recently
from
79a424a to
87505aa
Compare
gagik
force-pushed
the
gagik/fix-tests
branch
4 times, most recently
from
ebf3f87 to
99cb569
Compare
gagik
changed the title
gagik
commented
Feb 11, 2025
| @@ -14,6 +14,10 @@ on: | |||
| permissions: | |||
| contents: read # we just need to checkout the repo | |||
|
|
|||
| concurrency: | |||
There was a problem hiding this comment.
Drive-by improvement to cancel running tasks if a new commit is pushed
Currently even if a lerna npm task fails, lerna still exits with success and so does the CI task. This is because NPM v8 not sending the correct exit code. NPM v9 fixed this so this updates to that.
gagik
force-pushed
the
gagik/fix-tests
branch
from
99cb569 to
aeb3ccd
Compare
lerouxb
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently even if a lerna task fails, lerna still exits with success and so does the CI task.
The cause is the same as mongodb-js/mongosh#1592 with NPM not sending the correct exit code. NPM 9 fixed this so this updates to that.
Example of a task which will actually fail now: https://github.com/mongodb-js/devtools-shared/actions/runs/13263792191/job/37026159185?pr=508