Skip to content

Conversation

gagik
Copy link
Collaborator

@gagik gagik commented Feb 12, 2025

We're applying a writer.end() to be consistent with other places of properly cleaning the writer after creation as it messes with Windows CI tests.

// Still clean up here because Windows doesn’t like open files:
writer.end();
await once(writer, 'finish');

@gagik gagik merged commit 693a608 into main Feb 12, 2025
6 checks passed
@gagik gagik deleted the gagik/fix-windows-tests branch February 12, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants