Skip to content

fix(tests): clean up writer to prevent windows test failure #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix(tests): clean up writer to prevent windows test failure #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/mongodb-log-writer/src/mongo-log-manager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ describe('MongoLogManager', function () {

const writer = await manager.createLogWriter();
expect(writer.logFilePath as string).to.match(/custom_/);

writer.end();
await once(writer, 'finish');
});

it('cleans up old log files when requested', async function () {
Expand Down Expand Up @@ -577,7 +580,9 @@ describe('MongoLogManager', function () {
},
close: sinon.stub().resolves(),
};
const opendirStub = sinon.stub(fs, 'opendir').resolves(fakeDirHandle as any);
const opendirStub = sinon
.stub(fs, 'opendir')
.resolves(fakeDirHandle as any);

retentionDays = 0.000001; // 86.4 ms
const manager = new MongoLogManager({
Expand Down