feat(mongodb-log-writer): skip checks for retentionGB and maxLogFileCount when set to Infinity MONGOSH-2047
#515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
changed the title
retentionGB and `maxLogFi…retentionGB and maxLogFileCount when set to Infinity MONGOSH-2047
5 tasks
gagik
commented
Mar 5, 2025
| } | ||
| } | ||
|
|
||
| if (this._options.retentionGB) { | ||
| if (hasRetentionGB && this._options.retentionGB) { |
There was a problem hiding this comment.
I realize this is redundant but TypeScript isn't smart enough to do type promotion otherwise
gagik
force-pushed
the
gagik/skip-infinity-checks
branch
from
4b3d98a to
bfdc854
Compare
…leCount` when set to Infinity MONGOSH-2047
gagik
force-pushed
the
gagik/skip-infinity-checks
branch
from
bfdc854 to
ad59efa
Compare
addaleax
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because in mongosh (and generally), some of our settings like
logRetentionGBcan be undefined while others likemaxLogFileCountcannot, it's likely users will end up setting multiple of them asInfinityif they're looking to unset different things.Our code skips some checks when some steps when those limits are
undefinedbut it won't skip if they're infinite so it can be a performance improvement if we skip those steps if their values are infinite as well.