fix: explicitly specify and bump typescript related deps, fix debug filtering #554
Conversation
| @@ -54,7 +54,7 @@ | |||
| "dependencies": { | |||
| "debug": "^4.4.0", | |||
| "lodash": "^4.17.21", | |||
| "typescript": "^5.0.4" | |||
| "typescript": "^5.3.3" | |||
There was a problem hiding this comment.
Same version as in mongosh.
There was a problem hiding this comment.
Here in the repo the package-lock points to 5.8.2 anyway, feel free to also bump it to that in mongosh too (not a blocker for this PR really, the version here in package.json doesn't really matter anyway)
There was a problem hiding this comment.
I bumped it to 5.8.2 anyway now.
| @@ -63,6 +63,7 @@ | |||
| "@mongodb-js/tsconfig-devtools": "^1.0.3", | |||
| "@types/chai": "^4.2.21", | |||
| "@types/mocha": "^9.1.1", | |||
| "@types/node": "^22.15.30", | |||
There was a problem hiding this comment.
We didn't have this specified explicitly which might be why in mongosh the language server is using old types - could be that it is just using the hoisted version of @types/node there.
| result.fileName === '/shell-api.ts' || | ||
| result.fileName?.startsWith('/connection-') | ||
| ) { | ||
| if (result.fileName?.endsWith('shell-api.ts')) { |
There was a problem hiding this comment.
connection files actually start with connection_, not connection- but it is only the -shell-api.ts ones that are huge and clog up debug output, causing it to be cut off and then we can't see all the actual errors.
| @@ -54,7 +54,7 @@ | |||
| "dependencies": { | |||
| "debug": "^4.4.0", | |||
| "lodash": "^4.17.21", | |||
| "typescript": "^5.0.4" | |||
| "typescript": "^5.3.3" | |||
There was a problem hiding this comment.
Here in the repo the package-lock points to 5.8.2 anyway, feel free to also bump it to that in mongosh too (not a blocker for this PR really, the version here in package.json doesn't really matter anyway)
No description provided.