Skip to content

fix: explicitly specify and bump typescript related deps, fix debug filtering #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

fix: explicitly specify and bump typescript related deps, fix debug filtering #554

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fc5649
filter out the shell-api text from debug results at new location, spe…
lerouxb Jun 30, 2025
6ff223f
use the same version of typescript as in mongosh
lerouxb Jun 30, 2025
73ef961
bump ts to match reality
lerouxb Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/ts-autocomplete/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"dependencies": {
"debug": "^4.4.0",
"lodash": "^4.17.21",
"typescript": "^5.0.4"
"typescript": "^5.3.3"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same version as in mongosh.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here in the repo the package-lock points to 5.8.2 anyway, feel free to also bump it to that in mongosh too (not a blocker for this PR really, the version here in package.json doesn't really matter anyway)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped it to 5.8.2 anyway now.

},
"devDependencies": {
"@mongodb-js/eslint-config-devtools": "0.9.11",
Expand All @@ -63,6 +63,7 @@
"@mongodb-js/tsconfig-devtools": "^1.0.3",
"@types/chai": "^4.2.21",
"@types/mocha": "^9.1.1",
"@types/node": "^22.15.30",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't have this specified explicitly which might be why in mongosh the language server is using old types - could be that it is just using the hoisted version of @types/node there.

"@types/sinon-chai": "^3.2.5",
"chai": "^4.5.0",
"depcheck": "^1.4.7",
Expand Down
5 changes: 1 addition & 4 deletions packages/ts-autocomplete/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,7 @@ function filterDiagnostics(diagnostics: ts.Diagnostic[]): {
..._.pick(item, 'messageText'),
};

if (
result.fileName === '/shell-api.ts' ||
result.fileName?.startsWith('/connection-')
) {
if (result.fileName?.endsWith('shell-api.ts')) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connection files actually start with connection_, not connection- but it is only the -shell-api.ts ones that are huge and clog up debug output, causing it to be cut off and then we can't see all the actual errors.

delete result.text;
}

Expand Down
Loading