fix(cli-repl): improve explicit display of special characters in output MONGOSH-1910 #2330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MONGOSH-1910 Escape control characters in output strings if there's a reasonable chance that their are (partially) coming from the server side, instead of printing them directly. We keep printing them directly when it's reasonably possible that they are being used intentionally for output control, e.g. when coming from `print()` or `console.log()` statements.
lerouxb
approved these changes
Jan 27, 2025
gagik
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape control characters in output strings if there's a reasonable chance that their are (partially) coming from the server side, instead of printing them directly. We keep printing them directly when it's reasonably possible that they are being used intentionally for output control, e.g. when coming from
print()orconsole.log()statements.