Skip to content

fix(e2e-tests): make version test independent of package.json files #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addaleax merged 3 commits into from
Feb 1, 2025
Merged

fix(e2e-tests): make version test independent of package.json files #2343

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96bb074
fix(e2e-tests): make version test independent of package.json files
addaleax Jan 31, 2025
13eec13
fix(e2e-tests): use contain instead of include for shell output
gagik Feb 1, 2025
1c0a655
fix(e2e-tests): use wait for prompt instead
gagik Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 17 additions & 25 deletions packages/e2e-tests/test/e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,25 @@ describe('e2e', function () {
const testServer = startSharedTestServer();

describe('--version', function () {
it('shows version and matches @mongosh/cli-repl', async function () {
const expectedPackageVersion: string =
// eslint-disable-next-line @typescript-eslint/no-var-requires
require('../package.json')['dependencies']['@mongosh/cli-repl'];
it('gives the same result with version(), --version and --build-info', async function () {
// version() sources its version data from the shell-api package's generated files,
// --version from the cli-repl package.json and --build-info from the generated build-info.json
// (if available), which should all match.
const shell = this.startTestShell({ args: ['--nodb'] });
const versionFromShellApi = (await shell.executeLine('version()'))
.replace(/>/g, '')
.trim();

const shell = this.startTestShell({ args: ['--version'] });
await shell.waitForSuccessfulExit();
const versionShell = this.startTestShell({ args: ['--version'] });
await versionShell.waitForSuccessfulExit();
const versionFromCliFlag = versionShell.output.trim();

const buildInfoShell = this.startTestShell({ args: ['--build-info'] });
await buildInfoShell.waitForSuccessfulExit();
const versionFromBuildInfo = JSON.parse(buildInfoShell.output).version;

shell.assertContainsOutput(expectedPackageVersion);
expect(versionFromShellApi).to.equal(versionFromCliFlag);
expect(versionFromCliFlag).to.equal(versionFromBuildInfo);
});
});

Expand Down Expand Up @@ -479,24 +489,6 @@ describe('e2e', function () {
await client.close();
});

it('version', async function () {
const expectedPackageVersion: string =
// eslint-disable-next-line @typescript-eslint/no-var-requires
require('../package.json')['dependencies']['@mongosh/cli-repl'];

expect(expectedPackageVersion).not.null;

const versionShell = this.startTestShell({ args: ['--version'] });
await versionShell.waitForSuccessfulExit();

const versionFromShell = versionShell.output;

await shell.executeLine('version()');
shell.assertNoErrors();
shell.assertContainsOutput(expectedPackageVersion);
shell.assertContainsOutput(versionFromShell);
});

it('fle addon is available', async function () {
const result = await shell.executeLine(
'`<${typeof db._mongo._serviceProvider.createClientEncryption}>`'
Expand Down
Loading