feat(service-provider-core): support new BSON vector types in mongosh MONGOSH-1873 #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
commented
Apr 1, 2025
addaleax
reviewed
Apr 2, 2025
gagik
force-pushed
the
gagik/add-binary-types
branch
from
084e52c to
d93774d
Compare
gagik
commented
Apr 2, 2025
| depth, | ||
| ...options, | ||
| // These arrays can be very large, so would prefer to use the default options instead. | ||
| maxArrayLength: utilInspect.defaultOptions.maxArrayLength, |
Contributor
Author
There was a problem hiding this comment.
not sure if we want this, could remove. it just seems possible that these arrays can be very large I'd imagine so the {maxArrayLength: Infinity} that we're getting from
gagik
commented
Apr 2, 2025
| ) | ||
| ).matches( | ||
| // Precision is lost because of float handling, so we use regex to match | ||
| /Binary.fromFloat32Array\(new Float32Array\(\[ 1\.1\d*, 2\.2\d*, 3\.3\d* \]\)\)/ |
Contributor
Author
There was a problem hiding this comment.
not sure if we're meant to be dealing with float precision weirdness in JS in this case. can definitely see how it'd be weird to see imprecise floats while trying to inspect data. we could do something like https://github.com/mongodb-js/compass/pull/6834/files#diff-3d4b298fbb2cfe42467edc59277483eb9bcfdc46b07ea658ab3dc4f66903da88R174
gagik
changed the title
gagik
force-pushed
the
gagik/add-binary-types
branch
2 times, most recently
from
89ba28e to
ad3efe5
Compare
addaleax
approved these changes
Apr 3, 2025
| return binaryInspect.apply(this, args); | ||
| } | ||
| }, | ||
| } satisfies CustomInspectFunction, |
gagik
force-pushed
the
gagik/add-binary-types
branch
2 times, most recently
from
85d942b to
93b6028
Compare
gagik
force-pushed
the
gagik/add-binary-types
branch
from
93b6028 to
8d7c10e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add friendlier support for displaying BSON binary vector types in mongosh by displaying them as reproducable Binary constructor calls.
