Skip to content

chore(deps): update boxednode to 3.0.0, so we can support Node.js 24 MONGOSH-2995 #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmruiz merged 9 commits into from
Nov 24, 2025
Merged

chore(deps): update boxednode to 3.0.0, so we can support Node.js 24 MONGOSH-2995 #2582

kmruiz merged 9 commits into from
Nov 24, 2025

Conversation

@kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Nov 18, 2025 •
edited
Loading

No description provided.

@kmruiz kmruiz requested review from addaleax and Copilot November 18, 2025 13:59
@kmruiz kmruiz requested a review from a team as a code owner November 18, 2025 13:59
@kmruiz kmruiz added the dependencies Pull requests that update a dependency file label Nov 18, 2025
@kmruiz
chore: Update boxednode to 3.0.0, so we can support Node.js 24
148bd0f 
We are also upgrading the Node.js version we use for the driver
nightly tests to 24.11.1 (latest LTS version at the moment of
this commit)
@kmruiz kmruiz force-pushed the chore/MONGOSH-2995 branch from dac3f59 to 148bd0f Compare November 18, 2025 14:00
Copilot finished reviewing on behalf of kmruiz November 18, 2025 14:00
Copilot AI reviewed Nov 18, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the boxednode dependency from version 2.4.3 to 3.0.0 to enable support for Node.js 24, and updates the Node.js version used in driver nightly tests to 24.11.1 (the latest LTS version).

  • Upgrades boxednode package to 3.0.0 with updated dependencies
  • Updates driver nightly test configuration to use Node.js 24.11.1
  • Brings in newer versions of build tooling dependencies (node-gyp 11.5.0, rimraf 6.1.0, etc.)

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/build/package.json Updates boxednode dependency from ^2.4.3 to ^3.0.0
package-lock.json Updates dependency tree with boxednode 3.0.0 and its new/updated transitive dependencies including node-gyp, cacache, rimraf, and various @isaacs packages
.evergreen-nightly-driver.yml Adds Node.js version parameter set to 24.11.1 for driver nightly tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kmruiz kmruiz force-pushed the chore/MONGOSH-2995 branch from 701e0d4 to de85175 Compare November 18, 2025 14:37
@kmruiz
chore: Upgrade node-gyp, when supported, so it works with clang-cl
42636f6 
Older versions of node-gyp use the /LCTG:INCREMENTAL flag, which
is not supported by clang-cl: it's only supported in the "standard"
msvc compiler.
@kmruiz kmruiz force-pushed the chore/MONGOSH-2995 branch from 8e46512 to 42636f6 Compare November 18, 2025 14:52
@kmruiz
chore: Upgrade dependencies and use bundled npm on smoke tests
65dcffe 
The latest Node.js version should provide the best npm version
with it. npm@10 is already older to what Node.js 24 provides
(npm@11).
@kmruiz
chore: Update to latest node-gyp. It should work with Node.js>=20
f5842e0
@kmruiz kmruiz requested a review from Copilot November 18, 2025 15:07
Copilot finished reviewing on behalf of kmruiz November 18, 2025 15:09
Copilot AI reviewed Nov 18, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gagik
gagik reviewed Nov 18, 2025
View reviewed changes
gagik
gagik approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@gagik gagik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no evergreen changes needed?
I guess it's just the driver nightly that this affects?

@kmruiz
Copy link
Contributor Author

kmruiz commented Nov 18, 2025

is there no evergreen changes needed? I guess it's just the driver nightly that this affects?

We are not releasing yet with Node.js 24, only running the tests with the latest driver .

@kmruiz kmruiz force-pushed the chore/MONGOSH-2995 branch 2 times, most recently from 71a537f to f3157d4 Compare November 20, 2025 12:42
@addaleax addaleax changed the title chore: Update boxednode to 3.0.0, so we can support Node.js 24 MONGOSH-2995 chore(deps): update boxednode to 3.0.0, so we can support Node.js 24 MONGOSH-2995 Nov 20, 2025
addaleax
addaleax reviewed Nov 20, 2025
View reviewed changes
addaleax
addaleax reviewed Nov 24, 2025
View reviewed changes
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Do you want to split out the changes to .evergreen.yml and .evergreen/constants.js into a separate PR so that CI for the rest of this passes?

@kmruiz
Copy link
Contributor Author

kmruiz commented Nov 24, 2025

Code LGTM

Do you want to split out the changes to .evergreen.yml and .evergreen/constants.js into a separate PR so that CI for the rest of this passes?

That makes sense. To be fair, I thought having the CI run on evergreen was going to be less work, that's why I was working on it on this PR, but I think at this point is better to split it into 2 PRs. I'll pick the commits working on evergreen and move them to another PR.

@kmruiz kmruiz force-pushed the chore/MONGOSH-2995 branch from f8a6f6c to b2b65e4 Compare November 24, 2025 11:11
@evergreen-ci-prod evergreen-ci-prod bot mentioned this pull request Nov 24, 2025
Merged
@kmruiz kmruiz merged commit 06cca65 into main Nov 24, 2025
149 of 153 checks passed
@kmruiz kmruiz deleted the chore/MONGOSH-2995 branch November 24, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@addaleax addaleax addaleax approved these changes

@gagik gagik gagik approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kmruiz @addaleax @gagik