chore(cli-repl): add debugging info to async-repl tests #2611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AsyncRepl tests have been flaky for a few runs on the waterfall now, this should help try to figure out why specifically that is the case.
There was a problem hiding this comment.
Pull request overview
This PR adds debugging information to help diagnose flaky AsyncRepl test failures. The changes enhance timeout handling and error reporting to provide more context when tests fail.
Key changes:
- Added configurable timeout with detailed error messages showing actual content when substring matching fails
- Replaced simple boolean flag with stream end tracking for better debugging
- Increased test suite timeout to accommodate potential delays
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
addaleax
added
the
no-title-validation
lerouxb
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsyncRepl tests have been flaky for a few runs on the waterfall now, this should help try to figure out why specifically that is the case.