Skip to content

chore(cli-repl): add debugging info to async-repl tests #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addaleax merged 2 commits into from
Dec 5, 2025
Merged

chore(cli-repl): add debugging info to async-repl tests #2611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1254a80
chore(cli-repl): add debugging info to async-repl tests
addaleax Dec 4, 2025
e47418c
fixup: no need for extra unhandled rejections
addaleax Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions packages/cli-repl/src/async-repl.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,35 @@ function createDefaultAsyncRepl(extraOpts: Partial<AsyncREPLOptions> = {}): {

async function expectInStream(
stream: Readable,
substring: string
substring: string,
timeoutMs: number | null = 5000
): Promise<void> {
let content = '';
let found = false;
for await (const chunk of stream) {
content += chunk;
if (content.includes(substring)) {
found = true;
break;
}
let ended = false;
const result = await Promise.race([
(async () => {
for await (const chunk of stream) {
content += chunk;
if (content.includes(substring)) {
break;
}
}
ended = true;
return 'normal-completion' as const;
})(),
...(timeoutMs ? [delay(timeoutMs).then(() => 'timeout' as const)] : []),
]);
if (result === 'timeout') {
throw new Error(
`Timeout waiting for substring: ${substring}, found so far: ${content} (ended = ${ended})`
);
}
expect(found).to.be.true;
expect(content).to.include(substring);
}

describe('AsyncRepl', function () {
before(function () {
this.timeout(10000);
// nyc adds its own SIGINT listener that annoys use here.
process.removeAllListeners('SIGINT');
});
Expand Down
Loading