chore: Rename realm occurrences to Atlas App Services & update Go version #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
reviewed
Feb 20, 2025
| @@ -7,6 +7,10 @@ COVERAGE=coverage.out | |||
| export PATH := ./bin:$(PATH) | |||
There was a problem hiding this comment.
GOLANCI_VERSION can be updated to v1.62.2 as in TF repo
There was a problem hiding this comment.
are we using COVERAGE?
yes
GOLANCI_VERSION can be updated to v1.62.2 as in TF repo
done
lantoli
reviewed
Feb 20, 2025
lantoli
reviewed
Feb 20, 2025
|
|
||
| go 1.18 | ||
| go 1.23 |
There was a problem hiding this comment.
as this is a module to be used by other programs, consider defining toolchain
There was a problem hiding this comment.
@lantoli can you educate me a bit on what exactly is the benefit of that?
Also, can you confirm if the latest version of toolchain should be used? I've added 1.23.1 for now
lantoli
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
**There are still some remaining occurrences in the codebase which will be removed in follow-up PRs of setting up this repository.
Jira ticket: CLOUDP-273338
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments