chore: Fixes broken CI by sed after cdk-import #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maastha
reviewed
May 21, 2025
| # Fix @typescript-eslint/no-shadow es-linter error in file federated-database-instance/index.ts | ||
| sed -e 's/map(y => toJson_TagSet(y))/map(x => toJson_TagSet(x))/g' "${dest}" > "${dest}.tmp" && mv "${dest}.tmp" "${dest}" | ||
|
|
||
| sed -e 's|@stylistic/max-len, ||g' -e 's|, @stylistic/quote-props||g' "${dest}" > "${dest}.tmp" && mv "${dest}.tmp" "${dest}" |
Collaborator
There was a problem hiding this comment.
can we add here details about WHY this is done?
lantoli
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
npm install -g cdk-importchanged the behavior (not locked to a version in any workflow)@stylistic/{rule-name}directly in the cdk.sh script.More context
The generated typescript code contained different @Stylistic linter rules that made our code-health pipeline fail (first failure about ~1 week ago, last OK ~3 weeks ago).
A bit more background. projen doesn't support eslint 9 yet, so the stylistic plugin for eslint is not generated. See more in the projen issues:
Eslint no longer functional due to deprecated configuration
support-implementation-issue
Type of change:
expected)
Required Checklist:
make fmtand formatted my codeFurther comments