Skip to content

chore: Fixes broken CI by sed after cdk-import #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

chore: Fixes broken CI by sed after cdk-import #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4122cd
fix: Remove stylistic linter rules from generated TypeScript files
EspenAlbert May 21, 2025
890fb97
update l1 resources
EspenAlbert May 21, 2025
3220906
chore: regenerate API.md
EspenAlbert May 21, 2025
baad371
address PR comment
EspenAlbert May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions API.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions scripts/cdk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,8 @@ sed -e 's/UNDERSCORE_//g' -e 's/HYPHEN_//g' -e 's/PERIOD_//g' -e 's/VALUE_//g' "
# Fix @typescript-eslint/no-shadow es-linter error in file federated-database-instance/index.ts
sed -e 's/map(y => toJson_TagSet(y))/map(x => toJson_TagSet(x))/g' "${dest}" > "${dest}.tmp" && mv "${dest}.tmp" "${dest}"

# Fix errors like `Definition for rule '@stylistic/max-len' was not found @stylistic/max-len` until eslint 9 is supported by projen: https://github.com/projen/projen/issues/3240
sed -e 's|@stylistic/max-len, ||g' -e 's|, @stylistic/quote-props||g' "${dest}" > "${dest}.tmp" && mv "${dest}.tmp" "${dest}"
Copy link
Collaborator

@maastha maastha May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add here details about WHY this is done?

Copy link
Collaborator Author

@EspenAlbert EspenAlbert May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea: updated in baad371


echo
echo "L1 CDK resource generated succesfully: ${resource}, CFN type: ${resourceType}"
18 changes: 18 additions & 0 deletions src/l1-resources/cluster/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,20 @@ export interface ProcessArgs {
*/
readonly minimumEnabledTlsProtocol?: string;

/**
* The TLS cipher suite configuration mode. Valid values include `CUSTOM` or `DEFAULT`. The `DEFAULT` mode uses the default cipher suites. The `CUSTOM` mode allows you to specify custom cipher suites for both TLS 1.2 and TLS 1.3. To unset, this should be set back to `DEFAULT`.
*
* @schema processArgs#TlsCipherConfigMode
*/
readonly tlsCipherConfigMode?: string;

/**
* The custom OpenSSL cipher suite list for TLS 1.2. This field is only valid when `tls_cipher_config_mode` is set to `CUSTOM`.
*
* @schema processArgs#CustomOpensslCipherConfigTls12
*/
readonly customOpensslCipherConfigTls12?: string[];

/**
* Flag that indicates whether the cluster disables executing any query that requires a collection scan to return results.
*
Expand Down Expand Up @@ -289,6 +303,10 @@ export function toJson_ProcessArgs(
FailIndexKeyTooLong: obj.failIndexKeyTooLong,
JavascriptEnabled: obj.javascriptEnabled,
MinimumEnabledTLSProtocol: obj.minimumEnabledTlsProtocol,
TlsCipherConfigMode: obj.tlsCipherConfigMode,
CustomOpensslCipherConfigTls12: obj.customOpensslCipherConfigTls12?.map(
(y) => y
),
NoTableScan: obj.noTableScan,
OplogSizeMB: obj.oplogSizeMb,
SampleSizeBIConnector: obj.sampleSizeBiConnector,
Expand Down
Loading