fix collisions with projected columns and order by columns #108
Conversation
timgraham
force-pushed
the
fix-collisions-with-columns-and-order-by-columns
branch
from
7141e8c to
fdc643b
Compare
|
I made a couple edits on the Django fork (see last commit there), so a few more aggregation_regress tests cases can run. Do you want to check the "To triage:" list under expected failures before merging (rather than adding more details in a follow-up commit)? |
timgraham
force-pushed
the
fix-collisions-with-columns-and-order-by-columns
branch
from
fdc643b to
1698963
Compare
yes, what is "the triage"? where can I find it? |
django_mongodb/features.py
Outdated
| "aggregation_regress.tests.AggregationTests.test_annotation", | ||
| "aggregation_regress.tests.AggregationTests.test_more_more3", | ||
| "aggregation_regress.tests.AggregationTests.test_more_more_more3", | ||
| # To triage: |
There was a problem hiding this comment.
Great tests, in the first one we have two issues:
- It is related with joins.
- the way that we are storing object_ids in Django models. we cannot store a char[24].
Note that : collection.find({'_id': '66c42726db971422470255ed'}) it won't match the thing that have the id ObjectId('66c42726db971422470255ed').
There was a problem hiding this comment.
the second test is fixed, just another collision. Fixed in the last commit and test removed from features.py
There was a problem hiding this comment.
I think we should open a new issue for the first one. It's out of aggregation's scope.
There was a problem hiding this comment.
Thanks. I squashed the third commit with the second since it was actually a regression in that commit.
WaVEV
force-pushed
the
fix-collisions-with-columns-and-order-by-columns
branch
from
48736c3 to
2621db9
Compare
timgraham
force-pushed
the
fix-collisions-with-columns-and-order-by-columns
branch
from
2621db9 to
9dd5f08
Compare
timgraham
changed the title
No description provided.