Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

amalhotra-mdb
Copy link
Collaborator

@amalhotra-mdb amalhotra-mdb commented Mar 12, 2025

DESCRIPTION

Add info to mongosync behavior page ab metadata databases created during migration.

STAGING

https://deploy-preview-651--docs-cluster-to-cluster-sync.netlify.app/reference/mongosync/mongosync-behavior/#mongosync-metadata

JIRA

https://jira.mongodb.org/browse/DOCSP-48242

BUILD LOG

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit dc8759a
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67d2f2f50b5ac40008599de2
😎 Deploy Preview https://deploy-preview-651--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @amalhotra-mdb! I've left a suggestion/question for your consideration.

Thanks!
Joe

~~~~~~~~~~~~~~~~~~~~~~

``mongosync`` stores its metadata in a database during migration. The metadata
database may be named any of the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verb suggestion/question]

I think we should update this to use a different modal verb. Genereally, we use "may" in the docs to indicate permission: https://www.mongodb.com/docs/meta/style-guide/writing/use-effective-verbs/#use-modal-verbs-accurately

Would it make sense to update to "The metadata database will be named one of the following:"? I'm not sure if this is technically correct, though. Are we saying that it will be just one of these, or could there be multiple databases?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review @jmd-mongo ! I confirmed with @FGasper that there can be multiple databases; for example, mongosync’s embedded verifier stores its metadata separately from the rest of mongosync. I updated the PR accordingly, LMK if the changes look ok to you!

@amalhotra-mdb amalhotra-mdb requested a review from jmd-mongo March 13, 2025 15:06
Copy link
Collaborator

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional updates, @amalhotra-mdb! This one LGTM at this point.

Thanks,
Joe

Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks!

@amalhotra-mdb amalhotra-mdb merged commit 8d1329a into mongodb:master Mar 13, 2025
4 checks passed
amalhotra-mdb added a commit to amalhotra-mdb/docs-cluster-to-cluster-sync that referenced this pull request Mar 13, 2025
* DOCSP-48242-mongosync-metadata-post-sync

* capitalize heading

* reviewer updates

* clarification

(cherry picked from commit 8d1329a)
amalhotra-mdb added a commit to amalhotra-mdb/docs-cluster-to-cluster-sync that referenced this pull request Mar 13, 2025
* DOCSP-48242-mongosync-metadata-post-sync

* capitalize heading

* reviewer updates

* clarification

(cherry picked from commit 8d1329a)
amalhotra-mdb added a commit to amalhotra-mdb/docs-cluster-to-cluster-sync that referenced this pull request Mar 13, 2025
* DOCSP-48242-mongosync-metadata-post-sync

* capitalize heading

* reviewer updates

* clarification

(cherry picked from commit 8d1329a)
@amalhotra-mdb
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.11
v1.10
v1.9
v1.8

Questions ?

Please refer to the Backport tool documentation

amalhotra-mdb added a commit to amalhotra-mdb/docs-cluster-to-cluster-sync that referenced this pull request Mar 13, 2025
* DOCSP-48242-mongosync-metadata-post-sync

* capitalize heading

* reviewer updates

* clarification

(cherry picked from commit 8d1329a)
amalhotra-mdb added a commit that referenced this pull request Mar 13, 2025
* DOCSP-48242-mongosync-metadata-post-sync

* capitalize heading

* reviewer updates

* clarification

(cherry picked from commit 8d1329a)
amalhotra-mdb added a commit that referenced this pull request Mar 13, 2025
* DOCSP-48242-mongosync-metadata-post-sync

* capitalize heading

* reviewer updates

* clarification

(cherry picked from commit 8d1329a)
amalhotra-mdb added a commit that referenced this pull request Mar 13, 2025
* DOCSP-48242-mongosync-metadata-post-sync

* capitalize heading

* reviewer updates

* clarification

(cherry picked from commit 8d1329a)
amalhotra-mdb added a commit that referenced this pull request Mar 13, 2025
* DOCSP-48242-mongosync-metadata-post-sync

* capitalize heading

* reviewer updates

* clarification

(cherry picked from commit 8d1329a)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants