This repository was archived by the owner on May 1, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[verb suggestion/question]
I think we should update this to use a different modal verb. Genereally, we use "may" in the docs to indicate permission: https://www.mongodb.com/docs/meta/style-guide/writing/use-effective-verbs/#use-modal-verbs-accurately
Would it make sense to update to "The metadata database will be named one of the following:"? I'm not sure if this is technically correct, though. Are we saying that it will be just one of these, or could there be multiple databases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review @jmd-mongo ! I confirmed with @FGasper that there can be multiple databases; for example,
mongosync
’s embedded verifier stores its metadata separately from the rest ofmongosync
. I updated the PR accordingly, LMK if the changes look ok to you!