Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

amalhotra-mdb
Copy link
Collaborator

@amalhotra-mdb amalhotra-mdb commented Mar 17, 2025

DESCRIPTION

Update mongosync docs w/ known normal cancellations & fatal cancellations.

STAGING

https://deploy-preview-671--docs-cluster-to-cluster-sync.netlify.app/reference/mongosync/mongosync-behavior/#resilience

JIRA

https://jira.mongodb.org/browse/DOCSP-48355

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 7ad9066
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67d88b2f42c3df00086cfcee
😎 Deploy Preview https://deploy-preview-671--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@gmiller-mdb gmiller-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amalhotra-mdb
Copy link
Collaborator Author

Hi @ajayvijayakumar123 , could you take a look at this PR for an external review, whenever you get a chance? Thank you!

``mongosync`` is still able to complete the sync. In the case that a
sync does not complete, ``mongosync`` writes a fatal log entry.

``mongosync`` only exits with an info level log when it sees a normal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I didn't mean for REP-5495 to generate a downstream DOCSP ticket. I think we should just document REP-5495's changes on the release notes based on the google doc.

I don't think we should include this in our general docs because it exposes too much information about our logs. We say that our logs are not versioned and can change at any time here. I think we can close this ticket as won't do.

@zhenxuanjameszhang do you have thoughts on this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think currently something is broken that if we select manual to add release notes, a DOCSP ticket will still be auto generated. I have noted that on the release process to improve.

I trust your judgement on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants