Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

DOCSP-48355-treat-non-known-cancellations-fatal #671

Closed
wants to merge 1 commit into from
Closed

DOCSP-48355-treat-non-known-cancellations-fatal #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions source/reference/mongosync/mongosync-behavior.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,15 @@ error occurs, the ``mongosync`` log may contain the word "error' but
``mongosync`` is still able to complete the sync. In the case that a
sync does not complete, ``mongosync`` writes a fatal log entry.

``mongosync`` only exits with an info level log when it sees a normal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I didn't mean for REP-5495 to generate a downstream DOCSP ticket. I think we should just document REP-5495's changes on the release notes based on the google doc.

I don't think we should include this in our general docs because it exposes too much information about our logs. We say that our logs are not versioned and can change at any time here. I think we can close this ticket as won't do.

@zhenxuanjameszhang do you have thoughts on this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think currently something is broken that if we select manual to add release notes, a DOCSP ticket will still be auto generated. I have noted that on the release process to improve.

I trust your judgement on this.

cancellation and crashes with a fatal level log for all other cases.

The known normal cancellations are:

- If the user calls ``pause``
- If a test calls ``cancel`` as part of normal operation
- If ``mongosync`` encounters signals from the ``sigChan`` in ``cmd``/``mongosync``/``main.go``

.. _c2c-mongosync-ddl:

Data Definition Language (DDL) Operations
Expand Down