Skip to content

Conversation

@ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Oct 11, 2024

DESCRIPTION

Updating screenshots on the views page to show the new UI and use Atlas sample databases

STAGING

https://deploy-preview-678--docs-compass.netlify.app/documents/view/

JIRA

https://jira.mongodb.org/browse/DOCSP-41054

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit 3228607
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/67095496a6635200087406ec
😎 Deploy Preview https://deploy-preview-678--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sarah-olson-mongodb sarah-olson-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ltran-mdb2, Nice work! I've added a suggestion that I think will help with the page navigability. Happy to chat if you want. Also an optional nit about image size. After that, LGTM!


.. tabs::

.. tab:: List View
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(suggestion)
It took me a minute to understand that the contents of the page changed for the rest of the page depending on what tab you select here. It might be worth mentioning.
Happy to chat if you want!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the wording to make it more clear that the selected view is shown in all examples

object nested within the ``restaurants`` collection documents. The
new tab displays the five properties of the ``address`` object:

.. figure:: /images/compass/doc-table-view-nested.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(suggestion -- existing content)
The encrypted fields image in the List View is sized differently from every other image on this page. It might be worth adjusting, while you're here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the image smaller so that it aligns better with the rest of the images but is still large enough to show the encrypted field

Copy link

@betsybutton betsybutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Lauren!

@ltran-mdb2 ltran-mdb2 merged commit 1ea3cf5 into mongodb:master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants