- 
                Notifications
    You must be signed in to change notification settings 
- Fork 81
DOCSP-41054-view-screenshots-update #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ✅ Deploy Preview for docs-compass ready!
 To edit notification comments on pull requests, go to your Netlify site configuration. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ltran-mdb2, Nice work! I've added a suggestion that I think will help with the page navigability. Happy to chat if you want. Also an optional nit about image size. After that, LGTM!
|  | ||
| .. tabs:: | ||
|  | ||
| .. tab:: List View | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(suggestion)
It took me a minute to understand that the contents of the page changed for the rest of the page depending on what tab you select here. It might be worth mentioning.
Happy to chat if you want!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the wording to make it more clear that the selected view is shown in all examples
| object nested within the ``restaurants`` collection documents. The | ||
| new tab displays the five properties of the ``address`` object: | ||
|  | ||
| .. figure:: /images/compass/doc-table-view-nested.png | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(suggestion -- existing content)
The encrypted fields image in the List View is sized differently from every other image on this page. It might be worth adjusting, while you're here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the image smaller so that it aligns better with the rest of the images but is still large enough to show the encrypted field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Lauren!
DESCRIPTION
Updating screenshots on the views page to show the new UI and use Atlas sample databases
STAGING
https://deploy-preview-678--docs-compass.netlify.app/documents/view/
JIRA
https://jira.mongodb.org/browse/DOCSP-41054
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?