Skip to content

Conversation

@matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented Mar 12, 2025

GODRIVER-3098

Summary

  • Sync SDAM spec tests at 348d2f39 to prepare for dropping support for MongoDB 3.6
  • Skip tests that were previous modified when copied into the Go Driver repo. Unskip with GODRIVER-2967.
    • TestUnifiedSpec/server-discovery-and-monitoring/unified/logging-loadbalanced.json/Topology_lifecycle
    • TestUnifiedSpec/server-discovery-and-monitoring/unified/logging-sharded.json/Topology_lifecycle
    • TestUnifiedSpec/server-discovery-and-monitoring/unified/logging-replicaset.json/Topology_lifecycle
    • TestUnifiedSpec/server-discovery-and-monitoring/unified/logging-standalone.json/Topology_lifecycle

Background & Motivation

Part of a stack of changes that must be reviewed in order:

  1. GODRIVER-3445 Move all logic for skipping spec tests by description into one place. #1985
  2. GODRIVER-3098 Sync SDAM spec tests at 348d2f39. #1986 (this PR)
  3. GODRIVER-3098 Drop support for MongoDB 3.6 #1988

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the review-priority-low Low Priority PR for Review: within 3 business days label Mar 12, 2025
@mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes SDAM spec tests to commit 348d2f39 in preparation for dropping support for MongoDB 3.6 and adjusts test skip logic accordingly. Key changes include:

  • Adding a new skip tests file (internal/spectest/skip.go) and updating skip logic in unified spec tests.
  • Removing redundant, hardcoded skipped test mappings in unified_spec_runner.
  • Updating YAML test files to revise maxWireVersion values from 6 to 21 and minor test naming adjustments.

Reviewed Changes

Copilot reviewed 222 out of 222 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/spectest/skip.go New file providing centralized skip test configuration.
internal/integration/unified_spec_test.go Updated to call the new CheckSkip function instead of using legacy mappings.
internal/integration/unified/unified_spec_runner.go Removed redundant skippedTests mapping in favor of centralized handling.
testdata/server-discovery-and-monitoring/*.yml Updated maxWireVersion from 6 to 21 to align with spec changes.
internal/serverselector/server_selector_test.go Removed manual filename trimming to simplify test naming.
bson/bson_corpus_spec_test.go Adjusted test naming for consistency and adherence to Go style.

qingyang-hu
qingyang-hu previously approved these changes Mar 17, 2025
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for merging once #1985 is merged.

@matthewdale matthewdale dismissed qingyang-hu’s stale review March 19, 2025 23:13

The merge-base changed after approval.

@matthewdale matthewdale force-pushed the godriver3098-sync-tests branch from 8c8559b to e48a5e8 Compare March 19, 2025 23:14
@matthewdale matthewdale requested a review from qingyang-hu March 19, 2025 23:14
@matthewdale matthewdale merged commit ea8a75c into mongodb:master Mar 22, 2025
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-priority-low Low Priority PR for Review: within 3 business days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants