Skip to content

Fix panic in TestCollection/insert_many when nothing is inserted. #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Fix panic in TestCollection/insert_many when nothing is inserted. #1991

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c1a3fe
Fix panic in TestCollection/insert_many when nothing is inserted.
matthewdale Mar 20, 2025
ed8c663
Merge branch 'master' into fix-test-coll-panic
matthewdale Mar 27, 2025
f6faa1e
Use require.Greater instead of an if.
matthewdale Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions internal/integration/collection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"go.mongodb.org/mongo-driver/v2/event"
"go.mongodb.org/mongo-driver/v2/internal/assert"
"go.mongodb.org/mongo-driver/v2/internal/integration/mtest"
"go.mongodb.org/mongo-driver/v2/internal/require"
"go.mongodb.org/mongo-driver/v2/mongo"
"go.mongodb.org/mongo-driver/v2/mongo/options"
"go.mongodb.org/mongo-driver/v2/mongo/writeconcern"
Expand Down Expand Up @@ -231,18 +232,27 @@ func TestCollection(t *testing.T) {
mt.Run(tc.name, func(mt *mtest.T) {
res, err := mt.Coll.InsertMany(context.Background(), docs, options.InsertMany().SetOrdered(tc.ordered))

assert.Equal(mt, tc.numInserted, len(res.InsertedIDs), "expected %v inserted IDs, got %v", tc.numInserted, len(res.InsertedIDs))
assert.Equal(mt, id, res.InsertedIDs[0], "expected inserted ID %v, got %v", id, res.InsertedIDs[0])
if tc.numInserted > 1 {
assert.NotNil(mt, res.InsertedIDs[1], "expected ID but got nil")
}

we, ok := err.(mongo.BulkWriteException)
assert.True(mt, ok, "expected error type %T, got %T", mongo.BulkWriteException{}, err)
numErrors := len(we.WriteErrors)
assert.Equal(mt, tc.numErrors, numErrors, "expected %v write errors, got %v", tc.numErrors, numErrors)
gotCode := we.WriteErrors[0].Code
assert.Equal(mt, errorDuplicateKey, gotCode, "expected error code %v, got %v", errorDuplicateKey, gotCode)

require.Greater(mt, len(res.InsertedIDs), 0, "expected at least one inserted ID")
assert.Equal(mt,
tc.numInserted,
len(res.InsertedIDs),
"expected %v inserted IDs, got %v",
tc.numInserted,
len(res.InsertedIDs))
assert.Equal(mt,
id,
res.InsertedIDs[0],
"expected ID to match")
if tc.numInserted > 1 {
assert.NotNil(mt, res.InsertedIDs[1], "expected ID but got nil")
}
})
}
})
Expand Down
Loading