fix wiremessage oob in case of intmin #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested changes
Jun 3, 2025
| func ReadMsgSectionRawDocumentSequence(src []byte) (identifier string, data []byte, rem []byte, ok bool) { | ||
| length, rem, ok := readi32(src) | ||
| if !ok || int(length) > len(src) || length-4 < 0 { | ||
| if !ok || int(length) > len(src) || length < 0 || length-4 < 0 { |
There was a problem hiding this comment.
Suggest checking length < 4 instead of length < 0 || length-4 < 0 .
We should also add a test for this.
There was a problem hiding this comment.
indeed, seems better
|
@kobrineli I'm closing this PR for the time being. If you're still interested in making the change, please open a new pull request with the suggestion applied. |
prestonvasquez
requested review from
matthewdale
and removed request for
matthewdale
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
prestonvasquez
approved these changes
Jul 2, 2025
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Jul 31, 2025
Co-authored-by: Preston Vasquez <[email protected]>
alcaeus
added a commit
that referenced
this pull request
Aug 5, 2025
* master: (65 commits)
Replace all uses of 'interface{}' with 'any' in the bson package. (#2138)
GODRIVER-3473 Short-cicruit cursor.next() on invalid timeouts (#2135)
GODRIVER-3622 Automatically retry some test tasks. (#2147)
Replace all uses of 'interface{}' with 'any' in the repo docs. (#2142)
GODRIVER-3102: Perf comparison (#2134)
GODRIVER-3587 Use raw bytes in valueReader (#2120)
Replace all uses of 'interface{}' with 'any' in the internal/ packages. (#2140)
Replace all uses of 'interface{}' with 'any' in the x/ packages. (#2137)
GODRIVER-2016 Unskip all Transactions unified spec tests. (#2132)
GODRIVER-2540 Run govulncheck in CI builds. (#2136)
GODRIVER-3549 Update Client BulkWrite prose tests. (#2131)
Add guidelines for contributing features to the Go Driver (#2125)
Bump alcaeus/automatic-merge-up-action from 1.0.0 to 1.0.1 in the actions group (#2126)
Add wrappedMsgOnly to mongo.MarshalError and mongo.MongocryptError.
Bump testdata/specifications from `db69351` to `6689929`
fix wiremessage oob in case of intmin (#2076)
GODRIVER-3399: PoolClearedError should have TransientTransactionError label appended to it (#2114)
PR feedback.
Prevent integration tests from running when testing with -short
Skip AWS Test if no URI (#2102)
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't attach GODRIVER task number, 'cause I get 403 forbidden trying to access the project page.
Summary
If
lengthis in range fromINT_MIN(i.e. -2147483648) toINT_MIN+3,length-4 < 0check doesn't work as expected due to integer overflow.Getting too small length leads to check pass and further out of bound access.
Adding an additional check for length being smaller than zero solves the issue.