Skip to content

fix wiremessage oob in case of intmin #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2025
Merged

fix wiremessage oob in case of intmin #2076

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fca5906
fix wiremessage oob in case of intmin
kobrineli May 30, 2025
cc7f16f
Merge branch 'master' into fix-wiremessage-oob
prestonvasquez Jun 5, 2025
9eab72a
check length < 4 to avoid oob
prestonvasquez Jul 1, 2025
beed31e
Merge branch 'master' into fix-wiremessage-oob
prestonvasquez Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/mongo/driver/wiremessage/wiremessage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ func ReadMsgSectionDocumentSequence(src []byte) (identifier string, docs []bsonc
// sequence data.
func ReadMsgSectionRawDocumentSequence(src []byte) (identifier string, data []byte, rem []byte, ok bool) {
length, rem, ok := readi32(src)
if !ok || int(length) > len(src) || length-4 < 0 {
if !ok || int(length) > len(src) || length < 0 || length-4 < 0 {
Copy link
Member

@prestonvasquez prestonvasquez Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest checking length < 4 instead of length < 0 || length-4 < 0 .

We should also add a test for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, seems better

return "", nil, src, false
}

Expand Down
Loading