Replace all uses of 'interface{}' with 'any' in the mongo/ packages. #2139
+445
−445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
qingyang-hu
previously approved these changes
Aug 5, 2025
qingyang-hu
previously approved these changes
Aug 11, 2025
There was a problem hiding this comment.
Pull Request Overview
Replace all uses of interface{} with any in the mongo/ packages to adopt the cleaner syntax introduced in Go 1.18. This is a purely syntactic change with no semantic differences since any is a type alias for interface{}.
- Replace
interface{}withanyacross all function parameters, return types, struct fields, and variable declarations - Update function signatures in the MongoDB driver APIs to use the more modern syntax
- Maintain full backward compatibility as this is only a type alias change
Reviewed Changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mongo/writeconcern/writeconcern.go | Update WriteConcern struct field type |
| mongo/with_transactions_test.go | Update transaction callback function signatures |
| mongo/single_result.go | Update function parameters and return types |
| mongo/session.go | Update WithTransaction method signature |
| mongo/search_index_view.go | Update struct fields and method parameters |
| mongo/results.go | Update result struct field types |
| mongo/options/ (multiple files) | Update option struct fields and method parameters across all option builders |
| mongo/mongo.go | Update core marshal/unmarshal function signatures |
| mongo/index_view.go | Update IndexModel struct and method parameters |
| mongo/gridfs/ (multiple files) | Update GridFS-related types and method signatures |
| mongo/errors.go | Update MarshalError struct field type |
| mongo/doc.go | Update documentation comments |
| mongo/database.go | Update database method parameters |
| mongo/cursor.go | Update cursor method signatures |
| mongo/collection.go | Update collection method parameters and internal types |
| mongo/client.go | Update client method parameters and struct fields |
| mongo/change_stream.go | Update change stream related types |
| mongo/bulk_write.go | Update bulk write related types and method signatures |
| mongo/batch_cursor.go | Update interface method signature |
| mongo/background_context.go | Update context method signature |
🧪 Performance ResultsCommit SHA: 3f726dfThe following benchmark tests for version 689a3b15aaf5e20007e657d7 had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
qingyang-hu
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace all uses of
interface{}withanyin the "mongo/" packages.Background & Motivation
any is a type alias for
interface{}, so is semantically identical. The only change is a slightly cleaner syntax.