-
Notifications
You must be signed in to change notification settings - Fork 320
SPARK-414 support for delete #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+307
−195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VVBondarenko
commented
Aug 14, 2024
- added support for delete
- minor refactoring for filter transformations
- minor fix for catalog to load table with resolved schema instead of empty one
- added support for delete - minor refactoring for filter transformations - minor fix for catalog to load table with resolved schema instead of empty one
rozza
reviewed
Dec 1, 2025
Member
rozza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple of suggestions
src/main/java/com/mongodb/spark/sql/connector/ExpressionConverter.java
Outdated
Show resolved
Hide resolved
rozza
added a commit
to rozza/mongo-spark
that referenced
this pull request
Dec 3, 2025
- added support for delete - minor refactoring for filter transformations - minor fix for catalog to load table with resolved schema instead of empty one SPARK-414 Original PR: mongodb#124 --------- Co-authored-by: Ross Lawley <[email protected]>
Member
|
Closed in favor of: #144 - which takes this PR as a base |
rozza
added a commit
to rozza/mongo-spark
that referenced
this pull request
Dec 3, 2025
- added support for delete - minor refactoring for filter transformations - minor fix for catalog to load table with resolved schema instead of empty one SPARK-414 Original PR: mongodb#124 --------- Co-authored-by: Ross Lawley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.