Skip to content

Conversation

@rozza
Copy link
Member

@rozza rozza commented Dec 3, 2025

After reviewing the user prs, evergreen showed there were some changes required to normalize the code and ensure it works across the supported 3.x Spark versions.

So the initial code was reviewed and accepted for adoption.

See:

VVBondarenko-sbs and others added 4 commits December 3, 2025 14:52
To allow the overwrite save mode to keep collection options

SPARK-384

Original PR: mongodb#123 - removed recreate mode due to fragility
---------

Co-authored-by: Ross Lawley <[email protected]>
- added support for delete
- minor refactoring for filter transformations
- minor fix for catalog to load table with resolved schema instead of empty one

SPARK-414

Original PR: mongodb#124
---------

Co-authored-by: Ross Lawley <[email protected]>
Motivation: when using connector with thrift server, any queries on data containing date/time types are crashing. It's caused by thrift server enabling `spark.sql.datetime.java8API.enabled` flag for all of its sessions.

Supported JSR-310 types which are already supported by Spark SQL:
- LocalDate
- LocalDateTime
- Instant

Other types are causing Encoder to fail, so they won't work even if taken into account.

As `spark.sql.datetime.java8API.enabled` is disabled by default, it shouldn't cause compatibility issues.

Adds support for the Spark 3.4 TimeTimestampNTZType

SPARK-453

Original PR: mongodb#125
---------
Co-authored-by: Ross Lawley <[email protected]>
SPARK-449

Original PR: mongodb#140
---------
Co-authored-by: Ross Lawley <[email protected]>
@rozza rozza marked this pull request as ready for review December 3, 2025 15:47
@codeowners-service-app
Copy link

Assigned strogiyotec for team dbx-java because stIncMale is out of office.

@rozza rozza requested a review from nhachicha December 4, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants