Streaming added full document before change support #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Copilot finished reviewing on behalf of
rozza
December 1, 2025 09:41
There was a problem hiding this comment.
Pull request overview
This PR adds support for MongoDB change stream pre-images via the change.stream.lookup.full.document.before.change configuration option, enabling access to the full document state before delete, update, or replace operations. This is essential for preserving deleted document data for downstream consumers when the MongoDB deployment has pre-image collection enabled.
- Added new configuration constant
STREAM_LOOKUP_FULL_DOCUMENT_BEFORE_CHANGE_CONFIGwith comprehensive documentation - Implemented
getStreamFullDocumentBeforeChange()method to retrieve and validate the configuration value - Integrated
fullDocumentBeforeChange()calls in both streaming partition readers
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/mongodb/spark/sql/connector/config/ReadConfig.java | Adds configuration constant, default value, documentation, and getter method for full document before change support |
| src/main/java/com/mongodb/spark/sql/connector/read/MongoMicroBatchPartitionReader.java | Configures change stream iterable to use the full document before change setting |
| src/main/java/com/mongodb/spark/sql/connector/read/MongoContinuousPartitionReader.java | Configures change stream iterable to use the full document before change setting |
| src/test/java/com/mongodb/spark/sql/connector/config/MongoConfigTest.java | Adds comprehensive unit test covering all valid options (default, off, whenAvailable, required) and invalid input handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rozza
reviewed
Dec 1, 2025
src/main/java/com/mongodb/spark/sql/connector/config/ReadConfig.java
Outdated
Show resolved
Hide resolved
Fix javadoc issues
rozza
added a commit
to rozza/mongo-spark
that referenced
this pull request
Dec 3, 2025
SPARK-449 Original PR: mongodb#140 --------- Co-authored-by: Ross Lawley <[email protected]>
Member
|
Closed in favor of: #144 - which takes this PR as a base |
rozza
added a commit
to rozza/mongo-spark
that referenced
this pull request
Dec 3, 2025
SPARK-449 Original PR: mongodb#140 --------- Co-authored-by: Ross Lawley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We’re adding
change.stream.lookup.full.document.before.changeto ensure that we can access the full document prior to a delete operation in MongoDB change streams.This is particularly important for our use case where:
We’re setting this as a configurable option to remain compatible with MongoDB deployments.