-
Notifications
You must be signed in to change notification settings - Fork 13
CLOUDP-295785 - using build_info.json in new atomic pipeline #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaciejKaras
wants to merge
86
commits into
master
Choose a base branch
from
maciejk/use-ar-related-versions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build scenario Remove create and push manifests Continue improvement to main Simplify main and build_context missed Pass Build Configuration object directly Use legacy and new pipeline Fix Remove --include Rename MCO test image Multi platform builds, with buildx TODOs Implement is_release_step_executed() Fix init appdb image Import sort black formatting Some cleaning and version adjustments Adapt main to new build config Add buildscenario to buildconfig Handle build env Renaming, usage of high level config All images build pass on EVG Lint Explicit image type, support custom build_path Replace old by new pipeline in EVG Add documentation Split in multiple files, cleanup WIP, passing builds on staging temp + multi arch manifests Replace usage of sonar Remove namespace Remove pin_at and build_id Copied pipeline, removed daily builds and --exclude
This reverts commit 426e522.
This reverts commit d2a6153.
This reverts commit c6fc163.
…d-versions # Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/build/image_build_process.py # scripts/release/build_context.py
…d-versions # Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/build/image_build_process.py # scripts/release/pipeline_main.py
nammn
reviewed
Aug 8, 2025
nammn
reviewed
Aug 8, 2025
@@ -6,9 +6,7 @@ | |||
# | |||
# Ref: https://cryptography.io/en/latest/installation/#building-cryptography-on-linux | |||
# | |||
ARG GOLANG_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this chagne?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to align with other Dockerfiles, where Golang version is specified in base image
# Conflicts: # scripts/release/atomic_pipeline.py # scripts/release/pipeline_main.py
# Conflicts: # scripts/release/atomic_pipeline.py
nammn
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR focuses on using
build_info.json
information inatomic_pipeline.py
code. The logic is mostly hidden inimage_build_config_from_args
function. It is binding the parts from:build_info.json
with information for building imagesSection in Atomic Releases TD that describes the
build_info.json
and how it is used in the image building process.build_info.json
meko-tests
andmco-tests
images inbuild_info.json
agent
andops-manager
images inbuild_info.json
images_signing.py
fromscripts/evergreen/release
Proof of Work
CI tests passing + updated unit tests
Checklist
skip-changelog
label if not needed