Skip to content

Conversation

@EspenAlbert
Copy link
Contributor

@EspenAlbert EspenAlbert commented Nov 5, 2024

Proposed changes

  • Avoids runtime error: invalid memory address or nil pointer dereference when type!=DatabaseTrigger
  • Support using MONGODB_REALM_BASE_URL in profile (necessary for testing with cloud-dev) similar implementation to TF

Link to any related issue(s): CLOUDP-282800

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR has gone 30 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 30 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Dec 6, 2024
@github-actions github-actions bot removed the stale label Dec 31, 2024
@github-actions
Copy link
Contributor

This PR has gone 30 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 30 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@EspenAlbert EspenAlbert marked this pull request as ready for review March 18, 2025 15:26
@EspenAlbert EspenAlbert requested a review from a team as a code owner March 18, 2025 15:26
@maastha
Copy link
Collaborator

maastha commented Mar 18, 2025

Would MONGODB_REALM_BASE_URL be addressed as part of the other ticket https://jira.mongodb.org/browse/CLOUDP-282804? I'm assuming that would be relevant to run in CI right?

@EspenAlbert
Copy link
Contributor Author

Would MONGODB_REALM_BASE_URL be addressed as part of the other ticket https://jira.mongodb.org/browse/CLOUDP-282804? I'm assuming that would be relevant to run in CI right?

@maastha
Not sure, I removed it in 3de4c42 as I thought the changes made to appservices would address it. Should I add it back in?

@maastha
Copy link
Collaborator

maastha commented Mar 19, 2025

I think t's okay to do that in a separate PR if you want (or in the other ticket I mentioned),

edit: would just make sure to capture this in the ticket

@EspenAlbert EspenAlbert added this pull request to the merge queue Mar 19, 2025
Merged via the queue into master with commit 55626ad Mar 19, 2025
37 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-282800_trigger_nil_pointer branch March 19, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants