Skip to content

fix: Avoids runtime error: invalid memory address or nil pointer dereference when type!=DatabaseTrigger #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2025
Merged

fix: Avoids runtime error: invalid memory address or nil pointer dereference when type!=DatabaseTrigger #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0a1c8a
fix: runtime error: invalid memory address or nil pointer dereference…
EspenAlbert Nov 5, 2024
7cd5791
chore: supports setting baseURL on realm client when cloud-dev is used
EspenAlbert Nov 5, 2024
28a7488
chore: update trigger templates to use environment variables
EspenAlbert Dec 30, 2024
3de4c42
Merge branch 'master' into CLOUDP-282800_trigger_nil_pointer
EspenAlbert Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ update.json
**/functions/packages
**/taskcat_outputs/
**/inputs/**
**/samples/**
pytestdebug.log
!/cdk/**/.*
*.DS_Store
Expand Down
36 changes: 17 additions & 19 deletions cfn-resources/trigger/cmd/resource/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,28 +230,26 @@ func newEventTrigger(model *Model) (*appservices.EventTriggerRequest, error) {
conf.Database = *model.DatabaseTrigger.Database
}
dTrigger := model.DatabaseTrigger

if dTrigger.Match != nil {
jsonData := []byte(*dTrigger.Match)
// convert the JSON string to a map
var m interface{}
if err := json.Unmarshal(jsonData, &m); err != nil {
return nil, errors.New("error unmarshalling Match field - " + err.Error())
if dTrigger != nil {
if dTrigger.Match != nil {
jsonData := []byte(*dTrigger.Match)
// convert the JSON string to a map
var m interface{}
if err := json.Unmarshal(jsonData, &m); err != nil {
return nil, errors.New("error unmarshalling Match field - " + err.Error())
}
conf.Match = m
}
conf.Match = m
}

if dTrigger.Project != nil {
jsonData := []byte(*dTrigger.Project)
// convert the JSON string to a map
var m interface{}
if err := json.Unmarshal(jsonData, &m); err != nil {
return nil, errors.New("error unmarshalling Project field - " + err.Error())
if dTrigger.Project != nil {
jsonData := []byte(*dTrigger.Project)
// convert the JSON string to a map
var m interface{}
if err := json.Unmarshal(jsonData, &m); err != nil {
return nil, errors.New("error unmarshalling Project field - " + err.Error())
}
conf.Project = m
}
conf.Project = m
}

if dTrigger != nil {
conf.Collection = aws.StringValue(dTrigger.Collection)
conf.ServiceID = aws.StringValue(dTrigger.ServiceId)
conf.OperationTypes = dTrigger.OperationTypes
Expand Down
25 changes: 0 additions & 25 deletions cfn-resources/trigger/index.html
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions cfn-resources/trigger/test/inputs_1_create.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"Name": "materializeMonthlyProductSales46",
"Name": "cfn-test-trigger-${RANDOM_INT_100K}",
"Type": "DATABASE",
"Profile": "default",
"Profile": "${MONGODB_ATLAS_PROFILE}",
"DatabaseTrigger": {
"OperationTypes": [
"INSERT"
],
"Database": "store",
"Collection": "sales",
"ServiceId": "6387aee08659af5254b0a51e",
"ServiceId": "${MONGODB_REALM_SERVICE_ID}",
"FullDocument": "true",
"FullDocumentBeforeChange": "false",
"Unordered": "false",
Expand All @@ -20,14 +20,14 @@
"EventProcessors": {
"FUNCTION": {
"FuncConfig": {
"FunctionName": "cfn_func",
"FunctionId": "63862553ac0702272aa701ba"
"FunctionName": "${MONGODB_REALM_FUNCTION_NAME}",
"FunctionId": "${MONGODB_REALM_FUNCTION_ID}"
}
},
"AWSEVENTBRIDGE": {
"AWSConfig": {}
}
},
"AppId": "638624a5167f5659feb75971",
"ProjectId": "625454459c4e6108393d650d"
"AppId": "${MONGODB_REALM_APP_ID}",
"ProjectId": "${MONGODB_ATLAS_PROJECT_ID}"
}
14 changes: 7 additions & 7 deletions cfn-resources/trigger/test/inputs_1_update.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"Name": "materializeMonthlyProductSales46",
"Name": "cfn-test-trigger-${RANDOM_INT_100K}",
"Type": "DATABASE",
"Profile": "default",
"Profile": "${MONGODB_ATLAS_PROFILE}",
"DatabaseTrigger": {
"OperationTypes": [
"INSERT"
],
"Database": "store",
"Collection": "sales",
"ServiceId": "6387aee08659af5254b0a51e",
"ServiceId": "${MONGODB_REALM_SERVICE_ID}",
"FullDocument": "true",
"FullDocumentBeforeChange": "false",
"Unordered": "false",
Expand All @@ -20,14 +20,14 @@
"EventProcessors": {
"FUNCTION": {
"FuncConfig": {
"FunctionName": "cfn_func",
"FunctionId": "63862553ac0702272aa701ba"
"FunctionName": "${MONGODB_REALM_FUNCTION_NAME}",
"FunctionId": "${MONGODB_REALM_FUNCTION_ID}"
}
},
"AWSEVENTBRIDGE": {
"AWSConfig": {}
}
},
"AppId": "638624a5167f5659feb75971",
"ProjectId": "625454459c4e6108393d650d"
"AppId": "${MONGODB_REALM_APP_ID}",
"ProjectId": "${MONGODB_ATLAS_PROJECT_ID}"
}
Loading