Skip to content

Conversation

@EspenAlbert
Copy link
Contributor

@EspenAlbert EspenAlbert commented Dec 2, 2024

Set scopes in Read to support Scope updates

Link to any related issue(s): CLOUDP-287006 #1233

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@EspenAlbert EspenAlbert marked this pull request as ready for review December 2, 2024 11:08
@EspenAlbert EspenAlbert requested a review from a team as a code owner December 2, 2024 11:08
@EspenAlbert EspenAlbert added this pull request to the merge queue Dec 27, 2024
Merged via the queue into master with commit e1159b7 Dec 27, 2024
33 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-287006_database_user_update_scopes branch December 27, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants