Skip to content

chore(NODE-6459): compare CSOT performance #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 8, 2024
Merged

chore(NODE-6459): compare CSOT performance #4304

merged 10 commits into from
Nov 8, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Oct 31, 2024 •
edited
Loading

Description

What is changing?

  • Add new benchmark tasks for CSOT
    • set to 0, which means no timeouts are made
    • set to 120,000 ms so nothing actually times out but we are making timers
Is there new documentation needed for these changes?

No

What is the motivation for this change?

More perf data!

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the bench-csot branch 2 times, most recently from b3b79eb to c7cb12f Compare October 31, 2024 19:47
@nbbeeken nbbeeken force-pushed the NODE-6090 branch 2 times, most recently from 808c6f3 to 03e42d4 Compare November 5, 2024 20:05
Base automatically changed from NODE-6090 to main November 6, 2024 22:52
An error occurred while trying to automatically change base from NODE-6090 to main November 6, 2024 22:52
@nbbeeken nbbeeken force-pushed the bench-csot branch 2 times, most recently from 2598116 to 0e8c6c2 Compare November 6, 2024 22:53
@nbbeeken nbbeeken marked this pull request as ready for review November 7, 2024 15:41
nbbeeken
nbbeeken commented Nov 7, 2024
View reviewed changes
nbbeeken
nbbeeken commented Nov 7, 2024
View reviewed changes
nbbeeken
nbbeeken commented Nov 7, 2024
View reviewed changes
@nbbeeken nbbeeken changed the title perf(NODE-6459): compare CSOT performance chore(NODE-6459): compare CSOT performance Nov 8, 2024
@W-A-James W-A-James self-assigned this Nov 8, 2024
@W-A-James W-A-James self-requested a review November 8, 2024 16:16
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 8, 2024
W-A-James
W-A-James reviewed Nov 8, 2024
View reviewed changes
@nbbeeken nbbeeken requested a review from W-A-James November 8, 2024 18:26
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 8, 2024
@W-A-James W-A-James merged commit ed25d56 into main Nov 8, 2024
29 checks passed
@W-A-James W-A-James deleted the bench-csot branch November 8, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@W-A-James W-A-James W-A-James approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@W-A-James W-A-James

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nbbeeken @W-A-James