Skip to content

fix(NODE-6600): set object mode for message chunking correctly #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix(NODE-6600): set object mode for message chunking correctly #4345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a8dc2f
fix(NODE-6600): set object mode for message chunking correctly
addaleax Dec 3, 2024
b760405
Merge branch 'main' into 6600-dev
baileympearson Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cmap/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ export class SizedMessageTransform extends Transform {
connection: Connection;

constructor({ connection }: { connection: Connection }) {
super({ objectMode: false });
super({ writableObjectMode: false, readableObjectMode: true });
this.bufferPool = new BufferPool();
this.connection = connection;
}
Expand Down
18 changes: 17 additions & 1 deletion test/unit/cmap/connection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import {
MongoClientAuthProviders,
MongoDBCollectionNamespace,
MongoNetworkTimeoutError,
ns
ns,
SizedMessageTransform
} from '../../mongodb';
import * as mock from '../../tools/mongodb-mock/index';
import { getSymbolFrom } from '../../tools/utils';
Expand Down Expand Up @@ -323,4 +324,19 @@ describe('new Connection()', function () {
});
});
});

describe('SizedMessageTransform', function () {
it('parses chunks of wire messages', function () {
const stream = new SizedMessageTransform({ connection: {} as any });
// Message of length 4 + 4 = 8
stream.write(Buffer.from([8, 0, 0, 0]));
stream.write(Buffer.from([1, 2, 3, 4]));
// Message of length 4 + 2 = 6, chunked differently
stream.write(Buffer.from([6, 0, 0]));
stream.write(Buffer.from([0, 5, 6]));
expect(stream.read(1)).to.deep.equal(Buffer.from([8, 0, 0, 0, 1, 2, 3, 4]));
expect(stream.read(1)).to.deep.equal(Buffer.from([6, 0, 0, 0, 5, 6]));
expect(stream.read(1)).to.equal(null);
});
});
});
Loading