Skip to content

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jan 14, 2025

Description

What is changing?

  • Throws the error to the before hook if an error occurs
  • use the correct script name
  • use SCRIPT_NAME_STRING instead of NAME_STRING
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Calling the this.test.error(error) function was ending the test run early without error. Running all the tests would be a nice-to-have. 🙂

Fixing issue introduced in #4355.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review January 14, 2025 20:50
@W-A-James W-A-James self-assigned this Jan 14, 2025
@W-A-James W-A-James self-requested a review January 14, 2025 21:36
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 14, 2025
@W-A-James W-A-James merged commit e2aa15c into main Jan 14, 2025
28 of 30 checks passed
@W-A-James W-A-James deleted the NODE-6664-fix-test-squash branch January 14, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants