Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Feb 18, 2025

Description

Reverts changes in tools for finding python3 that broken the AWS ECS tests. Companion PR: mongodb-labs/drivers-evergreen-tools#602

What is changing?

Moves the forced python3 find into our install dependencies script only when testing functionality with a native module.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6745

mongodb-labs/drivers-evergreen-tools#602

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title Node 6745 test(NODE-6745): only find python when installing native Feb 18, 2025
@durran durran marked this pull request as ready for review February 18, 2025 00:43
@durran durran requested a review from a team as a code owner February 18, 2025 00:43
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 18, 2025
@baileympearson baileympearson self-assigned this Feb 18, 2025
@baileympearson baileympearson self-requested a review February 18, 2025 18:01
@baileympearson baileympearson merged commit 45233da into main Feb 18, 2025
27 of 28 checks passed
@baileympearson baileympearson deleted the NODE-6745 branch February 18, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants