Skip to content

test(NODE-6745): only find python when installing native #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

test(NODE-6745): only find python when installing native #4422

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d98784c
test(NODE-6745): only find python when installing native
durran Feb 17, 2025
f6c1417
test: pin tools
durran Feb 17, 2025
51a70eb
chore: revert tools branch
durran Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1520,6 +1520,11 @@ tasks:
- auth
- kerberos
commands:
- command: expansions.update
type: setup
params:
updates:
- {key: NATIVE, value: 'true'}
- func: install dependencies
- func: run kerberos tests
- name: test-auth-ldap
Expand Down
8 changes: 7 additions & 1 deletion .evergreen/generate_evergreen_tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,13 @@ TASKS.push(
{
name: 'test-auth-kerberos',
tags: ['auth', 'kerberos'],
commands: [{ func: 'install dependencies' }, { func: 'run kerberos tests' }]
commands: [
updateExpansions({
NATIVE: 'true'
}),
{ func: 'install dependencies' },
{ func: 'run kerberos tests' }
]
},
{
name: 'test-auth-ldap',
Expand Down
7 changes: 7 additions & 0 deletions .evergreen/install-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ export NODE_LTS_VERSION=${NODE_LTS_VERSION:-16}
# be handled by this script in drivers tools.
source $DRIVERS_TOOLS/.evergreen/install-node.sh

if [ "$NATIVE" = "true" ]; then
# https://github.com/nodejs/node-gyp#configuring-python-dependency
. $DRIVERS_TOOLS/.evergreen/find-python3.sh
NODE_GYP_FORCE_PYTHON=$(find_python3)
export NODE_GYP_FORCE_PYTHON
fi

npm install "${NPM_OPTIONS}"

source $DRIVERS_TOOLS/.evergreen/init-node-and-npm-env.sh
2 changes: 1 addition & 1 deletion .evergreen/prepare-shell.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export PATH="$MONGODB_BINARIES:$PATH"

if [ ! -d "$DRIVERS_TOOLS" ]; then
# Only clone driver tools if it does not exist
git clone --depth=1 "https://github.com/mongodb-labs/drivers-evergreen-tools.git" "${DRIVERS_TOOLS}"
git clone --depth=1 --branch NODE-6745 "https://github.com/mongodb-labs/drivers-evergreen-tools.git" "${DRIVERS_TOOLS}"
fi

echo "installed DRIVERS_TOOLS from commit $(git -C "${DRIVERS_TOOLS}" rev-parse HEAD)"
Expand Down